Skip to content

✅ Stop testing against Node 18 #6019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2025
Merged

✅ Stop testing against Node 18 #6019

merged 1 commit into from
Jun 28, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jun 28, 2025

Description

Testing against Node 18 was causing issues with the bump of Jest to version 30. As such and because Node 18 is no longer an LTS version, we are removing it from our testing matrix.

Checklist — Don't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run pnpm run bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ✅ Add or update tests
  • Impacts: None

@dubzzz
✅ Stop testing against Node 18
ffada49 
Testing against Node 18 was causing issues with the bump of Jest to version 30. As such and because Node 18 is no longer an LTS version, we are removing it from our testing matrix.
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 28, 2025

⚠️ No Changeset found

Latest commit: ffada49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dubzzz dubzzz enabled auto-merge (squash) June 28, 2025 16:20
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 28, 2025

@fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@6019

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@6019

fast-check

npm i https://pkg.pr.new/fast-check@6019

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@6019

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@6019

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@6019

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@6019

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@6019

commit: ffada49

@github-actions GitHub Actions
Copy link
Contributor

👋 A preview of the new documentation is available at: http://686017f15e5b1679910b2c46--dubzzz-fast-check.netlify.app

@codecov Codecov
Copy link

codecov bot commented Jun 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.95%. Comparing base (e43434b) to head (ffada49).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6019   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         212      212           
  Lines       10117    10117           
  Branches     2750     2752    +2     
=======================================
  Hits         9708     9708           
  Misses        409      409
Flag Coverage Δ
tests 95.95% <ø> (ø)
tests-against-22.x-on-macOS 95.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dubzzz dubzzz merged commit 248c751 into main Jun 28, 2025
45 checks passed
@dubzzz dubzzz deleted the stop-testing-against-node-18 branch June 28, 2025 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dubzzz