Skip to content

💚 Clean unhandled rejections in tests for scheduler #5608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2025
Merged

💚 Clean unhandled rejections in tests for scheduler #5608

merged 1 commit into from
Jan 14, 2025

Conversation

dubzzz
Copy link
Owner

@dubzzz dubzzz commented Jan 14, 2025

Description

Making tests around scheduler safer.

Checklist — Don't delete this checklist and make sure you do the following before opening the PR

  • The name of my PR follows gitmoji specification
  • My PR references one of several related issues (if any)
    • New features or breaking changes must come with an associated Issue or Discussion
    • My PR does not add any new dependency without an associated Issue or Discussion
  • My PR includes bumps details, please run yarn bump and flag the impacts properly
  • My PR adds relevant tests and they would have failed without my PR (when applicable)

Advanced

  • Category: ✅ Add or update tests
  • Impacts: None, more stable tests.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2025

⚠️ No Changeset found

Latest commit: 34b51ff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dubzzz dubzzz changed the title 💚 Clean unhandled rejections in tests for scheduler (#4716) 💚 Clean unhandled rejections in tests for scheduler Jan 14, 2025
@dubzzz dubzzz enabled auto-merge (squash) January 14, 2025 19:39
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 14, 2025

Open in Stackblitz • @fast-check/examples

@fast-check/ava

npm i https://pkg.pr.new/@fast-check/ava@5608

@fast-check/expect-type

npm i https://pkg.pr.new/@fast-check/expect-type@5608

fast-check

npm i https://pkg.pr.new/fast-check@5608

@fast-check/jest

npm i https://pkg.pr.new/@fast-check/jest@5608

@fast-check/poisoning

npm i https://pkg.pr.new/@fast-check/poisoning@5608

@fast-check/packaged

npm i https://pkg.pr.new/@fast-check/packaged@5608

@fast-check/vitest

npm i https://pkg.pr.new/@fast-check/vitest@5608

@fast-check/worker

npm i https://pkg.pr.new/@fast-check/worker@5608

commit: 34b51ff

@github-actions GitHub Actions
Copy link
Contributor

👋 A preview of the new documentation is available at: http://6786be6060e039dd2b2eb318--dubzzz-fast-check.netlify.app

@codecov Codecov
Copy link

codecov bot commented Jan 14, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.77%. Comparing base (40a23e1) to head (34b51ff).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5608   +/-   ##
=======================================
  Coverage   94.77%   94.77%           
=======================================
  Files         235      235           
  Lines       10034    10034           
  Branches     2825     2826    +1     
=======================================
  Hits         9510     9510           
  Misses        524      524
Flag Coverage Δ
unit-tests 94.77% <ø> (ø)
unit-tests-18.x-Linux 94.77% <ø> (ø)
unit-tests-20.x-Linux 94.77% <ø> (ø)
unit-tests-22.x-Linux 94.77% <ø> (ø)
unit-tests-latest-Linux 94.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dubzzz dubzzz merged commit 98c53e9 into main Jan 14, 2025
57 checks passed
@dubzzz dubzzz deleted the pr-4716 branch January 14, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dubzzz