🔥 Enforce run{Before/After}Each on property
#5581
Conversation
**:boom: Breaking change** The API of property has been updated in a non-breaking manner during v3. Now, let's seal that move to drop unneeded code complexity, drop useless tests... but also make the API clearer and way simpler to use and manage. The implementations of `IRawProperty` now have to implement `runBeforeEach` and `runAfterEach`. If they themselves wrap another `IRawProperty`, they probably should at least call these methods when called on their side of them. The migration from v3, consists into implementing the two methods.
🦋 Changeset detectedLatest commit: e7a3741 The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Open in Stackblitz • @fast-check/examples @fast-check/ava
@fast-check/expect-type
fast-check
@fast-check/jest
@fast-check/packaged
@fast-check/poisoning
@fast-check/vitest
@fast-check/worker
commit: |
|
👋 A preview of the new documentation is available at: http://677ec2612d825e645ab81360--dubzzz-fast-check.netlify.app |
|
👋 A preview of the new documentation is available at: http://677ec4081674becd216a8cc5--dubzzz-fast-check.netlify.app |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5581 +/- ##
==========================================
- Coverage 94.91% 94.90% -0.01%
==========================================
Files 235 235
Lines 10043 10024 -19
Branches 2836 2825 -11
==========================================
- Hits 9532 9513 -19
Misses 511 511
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Description
The API of property has been updated in a non-breaking manner during v3. Now, let's seal that move to drop unneeded code complexity, drop useless tests... but also make the API clearer and way simpler to use and manage.
The implementations of
IRawPropertynow have to implementrunBeforeEachandrunAfterEach. If they themselves wrap anotherIRawProperty, they probably should at least call these methods when called on their side of them. The migration from v3, consists into implementing the two methods.Checklist — Don't delete this checklist and make sure you do the following before opening the PR
yarn bumpand flag the impacts properlyAdvanced
💥 Breaking change: Change the execution flow of properties. Only impacts on advanced users building their own custom runners or their own property type.