Support postgresql 14 #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Nov 7, 2024
JelteF
reviewed
Nov 7, 2024
JelteF
reviewed
Nov 7, 2024
|
I am not sure if I need to make other modifications and whether it meets the requirements. If there is, guide me, hey hey 😀 |
JelteF
reviewed
Nov 7, 2024
JelteF
reviewed
Nov 11, 2024
JelteF
reviewed
Nov 11, 2024
922ab0d to
54e6ab6
Compare
This vendors in the PG14 version of the ruleutils.c file from Postgres. We've done the same already for PG15, PG16, and PG17, but now in preparation of PG14 support we also include the PG14 version.
PG14 support needs fairly minimal changes. Notable changes are: `\getenv` does not exist in psql for PG14, so we replace it's usages with `\set` commands. `ALTER TABLE ... SET ACCESS METHOD` does not exist in PG14, so we move the `ALTER TABLE` tests to `pycheck`. The PG14 ruleutils file misses some functions that exist in more recent versions. So we backport `GET_PRETTY_FLAGS` (which we changed) and `pg_get_querydef` (which we used).
Y--
approved these changes
Nov 12, 2024
|
Thanks @Leo-XM-Zeng I pushed this now as two separate commits to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support postgresql 14