Add GUC to allow DuckDB execution inside functions #884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Aug 14, 2025
src/pgduckdb_guc.cpp
Outdated
| @@ -143,6 +144,9 @@ InitGUC() { | |||
| /* pg_duckdb specific GUCs */ | |||
| DefineCustomVariable("duckdb.force_execution", "Force queries to use DuckDB execution", &duckdb_force_execution); | |||
|
|
|||
| DefineCustomVariable("duckdb.unsafe_allow_execution_inside_functions", "Allow DuckDB execution inside functions", | |||
| &duckdb_unsafe_allow_execution_inside_functions); | |||
There was a problem hiding this comment.
Given that this can introduce crashes I think a superuser should be configuring this.
Suggested change
| &duckdb_unsafe_allow_execution_inside_functions); | |
| &duckdb_unsafe_allow_execution_inside_functions, 0, GUC_SUPERUSER_ONLY); |
There was a problem hiding this comment.
Yes, that makes sense. But did you mean
&duckdb_unsafe_allow_execution_inside_functions, PGC_SUSET);
instead?
There was a problem hiding this comment.
Yes, that's definitely what I meant. After many years I still keep confusing these two.
JelteF
reviewed
Aug 14, 2025
| @@ -117,9 +118,8 @@ $$; | |||
| -- After executing the function the table should not contain the value 8, | |||
| -- because that change was rolled back | |||
| SELECT * FROM f(true); | |||
| ERROR: DuckDB execution is not supported inside functions | |||
There was a problem hiding this comment.
Do we still have some tests for the default behaviour?
There was a problem hiding this comment.
Yes, test/regression/expected/issue_730.out still uses the default behavior
https://github.com/duckdb/pg_duckdb/pull/764/files#diff-6e283896067d2e581c1917f5595977aa405d8f337cc77303a72e49dd9463eb26
JelteF
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuckDB execution inside functions was disallowed in #764 for good reason
However, some users depend on running analytics with pg_duckdb inside functions
Given that (1) the problematic cases are rare, and (2) pg_duckdb is mostly used for read queries, failures are limited to crashing the current session and can be recovered by restarting the session without data loss. This change introduces an unsafe GUC to restore this capability for users who need it