Support UUID in prepared statement #863
Merged
+22
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Aug 19, 2025
There was a problem hiding this comment.
I think this looks fine, but it's failing the linting/formmatting checks. Could you update it and update the tests here to include a test for UUIDs:
https://github.com/duckdb/pg_duckdb/blob/main/test/pycheck/prepared_test.py
|
Thanks, lint/format is fixed, and test is also added The PR was in draft state because while working on it, I noticed that many more types, not just UUID, are not supported in prepared statement: #861 (comment) |
2 tasks
JelteF
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.