Remove bigint epoch_ms function #840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuckDB 1.4 removes the bigint variant of epoch_ms for consistency: duckdb/duckdb#17816 This also removes that epoch_ms function for pg_duckdb, to avoid having to do a breaking change in the next release. This also removes the unresolved_type version of epoch_ms, as that can be used inadvertently to call the bigint one. Once pg_duckdb starts using DuckDB 1.4, we can add this back.
JelteF
added a commit
that referenced
this pull request
Aug 29, 2025
This reverts commit 81439c8. The change was reverted in duckdb, so we revert it here too. duckdb/duckdb#17908
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuckDB 1.4 removes the bigint variant of epoch_ms for consistency: duckdb/duckdb#17816
This also removes that epoch_ms function for pg_duckdb, to avoid having to do a breaking change in the next release.
This also removes the unresolved_type version of epoch_ms, as that can be used inadvertently to call the bigint one. Once pg_duckdb starts using DuckDB 1.4, we can add this back.