Fix SET TRANSACTION ISOLATION #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5797c5f to
07aae89
Compare
JelteF
commented
Jun 11, 2025
| @@ -20,5 +20,4 @@ ERROR: relation "do_not_exist" does not exist | |||
| LINE 1: SELECT * FROM do_not_exist; | |||
| ^ | |||
| END; | |||
| WARNING: pgduckdb: IsExtensionRegistered called in an aborted transaction | |||
There was a problem hiding this comment.
Not hitting this warning seems a nice side effect of this.
It was not possible to run transaction isolation commands when pg_duckdb was installed. This fixes that by not doing any queries when statements like that are being executed. Fixes #833
07aae89 to
3cf50b3
Compare
Y--
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was not possible to run transaction isolation commands when pg_duckdb
was installed. This fixes that by not doing any queries when statements
like that are being executed.
Fixes #833