Skip to content

Fix broken escaped LIKE expressions #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 5, 2025
Merged

Fix broken escaped LIKE expressions #815

merged 5 commits into from
Jun 5, 2025

Conversation

Y--
Copy link
Collaborator

@Y-- Y-- commented Jun 3, 2025 •
edited
Loading

Fix #813

@Y-- Y-- marked this pull request as draft June 3, 2025 16:35
@Y-- Y-- force-pushed the yl/fix-813 branch 3 times, most recently from 4d98b75 to 72d2d34 Compare June 4, 2025 09:05
@Y-- Y-- force-pushed the yl/fix-813 branch 2 times, most recently from ee7e98e to 1176223 Compare June 4, 2025 12:22
@Y-- Y-- requested a review from JelteF June 4, 2025 12:25
@Y-- Y-- marked this pull request as ready for review June 4, 2025 12:25
JelteF
JelteF reviewed Jun 4, 2025
View reviewed changes
JelteF
JelteF reviewed Jun 4, 2025
View reviewed changes
JelteF
JelteF reviewed Jun 4, 2025
View reviewed changes
Copy link
Collaborator

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test with non default ESCAPE characters in postgres.

@Y-- Y-- requested a review from JelteF June 4, 2025 16:08
@Y-- Y-- merged commit beaf84c into main Jun 5, 2025
6 checks passed
@Y-- Y-- deleted the yl/fix-813 branch June 5, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelteF JelteF JelteF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Escaping LIKE expressions is broken due to differences with PG and DuckDB
2 participants
@Y-- @JelteF