Only show hints about duckdb.row access for queries including duckdb functions #811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…functions We were adding hints to queries to which they did not apply. This is unhelpful and confusing for users. So this makes some changes to our logic for adding these hints to only do so when the query string includes the pg_duckdb functions that return a duckdb.row.
Y--
reviewed
Jun 3, 2025
| */ | ||
| edata->hint = pstrdup( | ||
| "If you use DuckDB functions like read_parquet, you need to use the r['colname'] syntax introduced " | ||
| "in pg_duckdb 0.3.0. It seems like you might be using the outdated \"AS (colname coltype, ...)\" " |
There was a problem hiding this comment.
Not for this PR but we'll probably want to drop old version refs before going 1.0
Y--
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were adding hints to queries to which they did not apply. This is
unhelpful and confusing for users. So this makes some changes to our
logic for adding these hints to only do so when the query string
includes the pg_duckdb functions that return a duckdb.row.