Fix scans larger than 2048 #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
previously approved these changes
May 26, 2025
JelteF
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #784 we introduced a memory context for Postgres scans, to avoid leaking "scratch space" used for things like jsonb serialization to string. It turned out that we were using this memory context too often, particularly around the call to
GetNextTuple(). By storing the current tuple in the ephemeral memory context, we would free it before callingGetNextTuple()in the next batch. This would in turn cause issues for index scans, which use the previous tuple to find the next tuple. This PR changes the code to only use the memory context when we're actually inserting the tuple in the DuckDB chunk.Fixes #796
Fixes #802