Fix CTAS with NUMERIC type #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #795 errors were added when using NUMERIC without a precision. It turns out that these were impossible to avoid for a CTAS command, because we didn't use the precision provided by DuckDB when creating the Postgres table. This fixes that and adds some tests to encode the current behaviour. Related to #795
Y--
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #795 errors were added when using NUMERIC without a precision. It
turns out that these were impossible to avoid for a CTAS command,
because we didn't use the precision provided by DuckDB when creating the
Postgres table. This fixes that and adds some tests to encode the
current behaviour.
Related to #795