Fix type mismatch issues with CTAS and materialized views #706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e9d7c44 to
27c06bb
Compare
DuckDB and Postgres can return different types for the same queries. This can confuse Postgres in various ways when these queries are involved in CTAS or materialized views. This fixes a bunch of issues related to that and adds appropriate regression tests.
27c06bb to
09f63d1
Compare
Y--
reviewed
Apr 16, 2025
src/pgduckdb_ddl.cpp
Outdated
Comment on lines
316
to
317
| auto save_nestlevel = NewGUCNestLevel(); | ||
| SetConfigOption("duckdb.force_execution", "true", PGC_USERSET, PGC_S_SESSION); |
There was a problem hiding this comment.
Do we have to go through the GUC? Why not using a different "force_execution" that would override it? Is it to limit the changes in this PR?
There was a problem hiding this comment.
Fixed now by calling DuckdbPlanNode directly.
Co-authored-by: Y. <y.lemaout@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuckDB and Postgres can return different types for the same queries.
This can confuse Postgres in various ways when these queries are
involved in CTAS or materialized views. This fixes a bunch of issues
related to that and adds appropriate regression tests.
This includes a fix for the materialized view issue that was found in #583