Disallow different encodings than UTF8 #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DuckDB only supports UTF8 and our string conversion between Postgres and DuckDB strings doesn't handle converting encodings, probably resulting into crashes if you try to use pg_duckdb with a Postgres in a non-UTF8 encoding. Given that databases with non-UTF8 encodings are very rare these days (only really ancient databases) it seems fine to not support them at all. So this starts throwing an error.
Y--
approved these changes
Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DuckDB only supports UTF8 and our string conversion between Postgres and
DuckDB strings doesn't handle converting encodings, probably resulting
into crashes if you try to use pg_duckdb with a Postgres in a non-UTF8
encoding. Given that databases with non-UTF8 encodings are very rare
these days (only really ancient databases) it seems fine to not support
them at all. So this starts throwing an error.
Fixes #238