Skip to content

Add Support for Duckdb Map type #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2025
Merged

Add Support for Duckdb Map type #689

merged 2 commits into from
Apr 1, 2025

Conversation

shah-nirmit
Copy link
Contributor

@shah-nirmit shah-nirmit commented Mar 23, 2025 •
edited
Loading

Resolves #600

Also did not need new subscript functions as unresolved subscript functions already takes care of this. See below

postgres=# select r['mp'][100] from duckdb.query($$ select mp from tbl1 $$) r;
 r.mp[100] 
-----------
         1
(1 row)

postgres=# select r['mp'][200] from duckdb.query($$ select mp from tbl1 $$) r;
 r.mp[200] 
-----------
         2
(1 row)

postgres=# select r['mp'][1] from duckdb.query($$ select mp from tbl1 $$) r;
 r.mp[1] 
---------
        
(1 row)

postgres=# select * from duckdb.query($$ select mp[100] from tbl1 $$) r;
 mp[100] 
---------
       1
(1 row)

postgres=# select * from duckdb.query($$ select mp[200] from tbl1 $$) r;
 mp[200] 
---------
       2
(1 row)

@shah-nirmit
Add Support for Duckdb Map type and enable tests
0ba5729 
Signed-off-by: Nirmit Shah <nirmitshah191@gmail.com>
Y--
Y-- reviewed Mar 24, 2025
View reviewed changes
@shah-nirmit shah-nirmit requested a review from Y-- March 29, 2025 03:01
@shah-nirmit
Copy link
Contributor Author

@Y-- can you please review again , thanks

Y--
Y-- approved these changes Apr 1, 2025
View reviewed changes
Copy link
Collaborator

@Y-- Y-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the extra iterations!

@Y-- Y-- merged commit e99ab5d into duckdb:main Apr 1, 2025
6 checks passed
@JelteF JelteF mentioned this pull request Apr 23, 2025
Closed
@JelteF JelteF mentioned this pull request May 8, 2025
Merged
JelteF added a commit that referenced this pull request May 8, 2025
@JelteF
Support subscripting on duckdb.map (#773)
f16bbd7 
In #689 the subscript operator was not implemented for the duckdb.map
type. This worked fine for MAPs returned by `duckdb.query()` because
that returned duckdb.unresolved_type. But not when getting a map from a
`duckdb` table column, i.e. a MotherDuck table. So this implements the
subscript operator directly on the `duckdb.map` type.

Fixes #732
@JelteF JelteF mentioned this pull request May 8, 2025
Open
JelteF added a commit that referenced this pull request May 9, 2025
@JelteF
Support subscripting on duckdb.map (#773)
fa2b37c 
In #689 the subscript operator was not implemented for the duckdb.map
type. This worked fine for MAPs returned by `duckdb.query()` because
that returned duckdb.unresolved_type. But not when getting a map from a
`duckdb` table column, i.e. a MotherDuck table. So this implements the
subscript operator directly on the `duckdb.map` type.

Fixes #732
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-- Y-- Y-- approved these changes

+1 more reviewer

@destrex271 destrex271 destrex271 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support the DuckDB MAP type
3 participants
@shah-nirmit @Y-- @destrex271