Fix issue with too long schema names breaking MotherDuck sync #680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have a database+schema that would result in a `ddb$` schema with more than 63 characters it would completely break the MotherDuck background syncing, due to an error-restart-loop. This changes the code to skip that schema. It also codes a bit more defensively in the place where it was also previously throwing the error continuously. If the schema cannot be found when we try to add a dependency for it, we say that we failed to create the schema and skip it instead of getting into this error loop.
Y--
approved these changes
Mar 20, 2025
Co-authored-by: Y. <y.lemaout@gmail.com>
JelteF
commented
Mar 20, 2025
Y--
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have a database+schema that would result in a
ddb$schema withmore than 63 characters it would completely break the MotherDuck
background syncing, due to an error-restart-loop. This changes the code
to skip that schema.
It also codes a bit more defensively in the place where it was also
previously throwing the error continuously. If the schema cannot be found
when we try to add a dependency for it, we say that we failed to create
the schema and skip it instead of getting into this error loop.