Skip to content

Add cast from unresolved_type to bytea #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2025
Merged

Add cast from unresolved_type to bytea #667

merged 1 commit into from
Mar 14, 2025

Conversation

JelteF
Copy link
Collaborator

@JelteF JelteF commented Mar 14, 2025

This was a CAST that I missed, when adding most other casts in #531. The missing cast was reported on Discord by someone trying to get the spatial extension working in pg_duckdb.

@JelteF
Add cast from unresolved_type to bytea
daaf861 
This was a CAST that I missed, when adding most other casts in #531.
The missing cast was reported on Discord by someone trying to get the
spatial extension working in pg_duckdb.
@JelteF JelteF enabled auto-merge (squash) March 14, 2025 09:59
Y--
Y-- reviewed Mar 14, 2025
View reviewed changes
Copy link
Collaborator

@Y-- Y-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have a test? :)

@JelteF
Copy link
Collaborator Author

JelteF commented Mar 14, 2025

Can we have a test? :)

I thought about that, but I didn't add any tests for the other casts either. So seemed weird to have one only for bytea. I cannot think of way that we can somehow break these casts in the future, so I'm not really worried about regressions. So adding tests for all casts seems like a waste of CI time to me.

@JelteF JelteF merged commit def7c60 into main Mar 14, 2025
5 checks passed
@JelteF JelteF deleted the add-bytea-cast branch March 14, 2025 14:09
@Y--
Copy link
Collaborator

Y-- commented Mar 14, 2025

Can we have a test? :)

I thought about that, but I didn't add any tests for the other casts either. So seemed weird to have one only for bytea. I cannot think of way that we can somehow break these casts in the future, so I'm not really worried about regressions. So adding tests for all casts seems like a waste of CI time to me.

Ok fair enough. I wonder if there could be a systematic way to loop over every type to pro-actively find these issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-- Y-- Y-- approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JelteF @Y--