Add additional functionality for the duckdb.unresolved_type #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3a5fc7 to
9a8a8ac
Compare
In 0.3.0 we added the `duckdb.unresolved_type` type and implemented a bunch of operators, aggregates and functions for it. Ofcourse the list will always be incomplete and casts to actual types might always be necessary in some cases. But for usability we should still try to implement the most commonly used functionality. So this adds a bunch of additional things that I ran into over the past weeks: 1. The `min` aggregate, this was not present in 0.3.0 by accident. Probably because duckdb has two `min` aggregates. 2. Casts to `time`, `timetz`, `interval` and `bit` 3. Support for `date_trunc`, `length` and `regexp_replace` 4. Add general support for the `strftime` and `strptime` functions. This is useful even for already resolved/casted `timestamp`/`date` values because Postgres its date formatting functions like `to_char` are not available in DuckDB.
9a8a8ac to
61bef69
Compare
Y--
reviewed
Mar 7, 2025
| GetConfigOption(const char *name, bool missing_ok, bool restrict_privileged) { | ||
| return PostgresFunctionGuard(::GetConfigOption, name, missing_ok, restrict_privileged); | ||
| } | ||
| } // namespace pgduckdb::pg |
There was a problem hiding this comment.
I'm a bit on the fence since they're only used in one file, but should we move the DefineCustomVariable helpers from pgduckdb.cpp here?
There was a problem hiding this comment.
I think we should make all our functions in src/pg/*.cpp files be functions that are safe to call from C++. Since DefineCustomVariable are not, and don't really make sense to be, since they are called from _PG_init, I don't think that makes sense to move them. I'd like to move all our GUC definitions to a different file in general though.
Y--
approved these changes
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0.3.0 we added the
duckdb.unresolved_typetype and implemented a bunch of operators, aggregates and functions for it. Of course the list will always be incomplete and casts to actual types might always be necessary in some cases. But for usability we should still try to implement the most commonly used functionality. So this adds a bunch of additional things that I ran into over the past weeks:minaggregate, this was not present in 0.3.0 by accident. Probably because DuckDB has twominaggregates.time,timetz,intervalandbitdate_trunc,lengthandregexp_replacestrftimeandstrptimefunctions. This is useful even for already resolved/castedtimestamp/datevalues because Postgres its date formatting functions liketo_charare not available in DuckDB.~,~~,~~*,!~,!~~, and !~~*`epoch/epoch_ms/epoch_us/epoch_nsfunctions. These are useful for lots of data processing tasks, because often timestamps are stored as a number relative to the epoch in data files/tables.To make the string of parsing/formatting of
strftime/strptimeconsistent this also starts syncing the PG timezone to DuckDB.