Start supporting DuckDB DDL in transactions #632
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ef82bfa to
b8fe67c
Compare
b8fe67c to
bf9b512
Compare
59bd596 to
d6d6954
Compare
mkaruza
approved these changes
Feb 28, 2025
This was referenced Mar 5, 2025
JelteF
added a commit
that referenced
this pull request
Mar 5, 2025
This fixes a handful of issues with MotherDuck tables that I ran into while implementing automated testing for MotherDuck integration: 1. When creating a table in a `ddb$` schema, default that table to be an MD table. 2. Do not allow creating non-MD tables in `ddb$` schemas when explicitly specifying another Table AM (like `heap`). 3. When creating MD tables, automatically make them owned by `duckdb.postgres_role` 4. Fix syncing of MotherDuck tables. This was broken by #632 5. Fix escaping of a MotherDuck schema name when syncing schema names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts supporting DuckDB DDL in transactions. There are still some limitations, but the most common use cases should now work as expected. For the cases that are disallowed, it's possible to disable the mixed-writes detection by setting
duckdb.unsafe_allow_mixed_transactionstotrue. This is not recommended for most usage, but it is a useful escape hatch for cases where people cannot manually control the transaction end/start.A major change this does in the detection is that it starts to completely rely on CommandId for detecting Postgres writes. Previously we also looked at WAL, but it turns out that is very unreliable, because even read queries can trigger WAL writes (e.g. to update hint bits).