Skip to content

Support INTERVAL type #573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 4, 2025
Merged

Support INTERVAL type #573

merged 2 commits into from
Feb 4, 2025

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Feb 4, 2025

Resolves #560

@dentiny dentiny force-pushed the hjiang/support-interval-type-2 branch from f048740 to b10947c Compare February 4, 2025 10:02
@dentiny dentiny force-pushed the hjiang/support-interval-type-2 branch from b10947c to b934d53 Compare February 4, 2025 10:03
JelteF
JelteF reviewed Feb 4, 2025
View reviewed changes
JelteF
JelteF requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Other than the missing test in prepared_test.py I think this looks perfect.

@dentiny dentiny requested a review from JelteF February 4, 2025 11:04
@JelteF JelteF merged commit 199311e into duckdb:main Feb 4, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JelteF JelteF JelteF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support INTERVAL type
2 participants
@dentiny @JelteF