Add tests for assigning aliases of different casing #565
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the `read_parquet` syntax from before #531 we had a bug where it was impossible to change casing of an alias from upper to lower: ``` select upper as "upper", lower as "LOWER" from read_parquet('/tmp/tmp.parquet') as t(upper int8, lower int8) limit 2; UPPER | LOWER -------+------- 0 | 0 1 | 1 (2 rows) ``` See #564 for more details. Luckily #531 has completely fixed this problem, so all this PR does is add some regression tests. Finally it also corrects the output file of the `case_insensitivity.sql` test, which was introduced by #563. It also adds that test to the `schedule` file, which was the reason that CI didn't notice that the output was wrong. Fixes #564 Related #563
Y--
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
read_parquetsyntax from before #531 we had a bug where it was impossible to change casing of an alias from upper to lower:See #564 for more details.
Luckily #531 has completely fixed this problem, so all this PR does is add some regression tests.
Finally it also corrects the output file of the
case_insensitivity.sqltest, which was introduced by #563. It also adds that test to theschedulefile, which was the reason that CI didn't notice that the output was wrong.Fixes #564
Related #563