Skip to content

Add implicit % to bridge TABLESAMPLE syntax #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 15, 2025
Merged

Add implicit % to bridge TABLESAMPLE syntax #559

merged 4 commits into from
Apr 15, 2025

Conversation

nbiscaro
Copy link
Contributor

@nbiscaro nbiscaro commented Jan 26, 2025 •
edited by JelteF
Loading

Bridge syntax differences in TABLESAMPLE by adding implicit %.

Fixes #558
Fixes #429

@nbiscaro nbiscaro mentioned this pull request Jan 26, 2025
Closed
@nbiscaro nbiscaro changed the title Add implicit % to bridge syntax Add implicit % to bridge TABLESAMPLE syntax Jan 26, 2025
JelteF
JelteF reviewed Jan 27, 2025
View reviewed changes
JelteF
JelteF requested changes Jan 27, 2025
View reviewed changes
Copy link
Collaborator

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! This needs some tests though.

@nbiscaro nbiscaro force-pushed the bridge-tablesample branch 2 times, most recently from 76966b8 to e216177 Compare January 30, 2025 23:56
@JelteF JelteF added this to the 0.4.0 milestone Feb 4, 2025
JelteF
JelteF requested changes Feb 26, 2025
View reviewed changes
Copy link
Collaborator

@JelteF JelteF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delayed response. This is a very useful feature. I left two small comments, but other than that I think this is good to merge.

@JelteF
Copy link
Collaborator

JelteF commented Mar 4, 2025

@nbiscaro do you still intend to address these comments?

@nbiscaro
Copy link
Contributor Author

nbiscaro commented Mar 5, 2025 •
edited
Loading

@nbiscaro do you still intend to address these comments?

Yes! Will get to this within the next 48 hours.

@JelteF
Copy link
Collaborator

JelteF commented Mar 18, 2025

@nbiscaro any progress?

@JelteF JelteF removed this from the 1.0.0 milestone Mar 21, 2025
@nbiscaro nbiscaro force-pushed the bridge-tablesample branch 3 times, most recently from 5218f5d to 048e885 Compare March 21, 2025 22:55
@JelteF JelteF enabled auto-merge (squash) March 22, 2025 23:06
@Y-- Y-- force-pushed the bridge-tablesample branch from 048e885 to e9c05c6 Compare April 2, 2025 09:28
@JelteF JelteF merged commit 57b59b4 into duckdb:main Apr 15, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-- Y-- Y-- approved these changes

@JelteF JelteF JelteF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature Request: Support TABLESAMPLE
3 participants
@nbiscaro @JelteF @Y--