Create dedicated cache FS #550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JelteF
reviewed
Jan 22, 2025
mkaruza
approved these changes
Jan 23, 2025
Y--
commented
Jan 23, 2025
| } | ||
|
|
||
| { | ||
| lock_guard<mutex> lock(cached_fs_mutex); |
There was a problem hiding this comment.
This is probably a bit overkill since GetFS is only called under a lock already, but feels more future-proof
JelteF
reviewed
Jan 23, 2025
| return LocalFileSystem::OpenFile(oss.str(), flags, opener); | ||
| } | ||
|
|
||
| void AssertSameCacheDir(const string &other_dir) { |
There was a problem hiding this comment.
When I read Assert I expect it's a thing that's only checked if assertions are enabled, so let's name this differently.
There was a problem hiding this comment.
Given it's only used in one place, maybe just inline it.
There was a problem hiding this comment.
But then I have to make the cache_file_directory public just for this method? I preferred to not leak it :-)
Co-authored-by: Jelte Fennema-Nio <jelte@motherduck.com>
This reverts commit 24891f4.
JelteF
reviewed
Jan 23, 2025
| @@ -78,6 +80,13 @@ class CachedFileHandle { | |||
| shared_ptr<CachedFile> file; | |||
| }; | |||
|
|
|||
| class LocalCacheFileSystem: public LocalFileSystem { | |||
| // TODO: we could lock down the LocalFileSystem to only allow path that are in the cache directory | |||
JelteF
approved these changes
Jan 23, 2025
JelteF
approved these changes
Jan 23, 2025
|
For posterity - we've discussed |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, non super-users are going to face an error when querying S3 objects like:
The reason is that the current cache mechanism uses the DB's
FileSystemwhich non-super users cannot access.To fix it, we create a dedicated FS that the extension is allow to access (but not the user directly).
cache_file_directory(no path)OpenFileare throwing a permission error.