Skip to content

[easy] [no-op] Suppress compiler warning #543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 16, 2025
Merged

[easy] [no-op] Suppress compiler warning #543

merged 2 commits into from
Jan 16, 2025

Conversation

dentiny
Copy link
Contributor

@dentiny dentiny commented Jan 16, 2025

... otherwise have compiler warning

[4/492] Building CXX object src/planner/binder...query_node.dir/ub_duckdb_bind_query_node.cpp.osrc/pgduckdb_detoast.cpp: In function 'varlena* pgduckdb::Lz4DecompresDatum(const varlena*)':
src/pgduckdb_detoast.cpp:53:41: warning: unused parameter 'value' [-Wunused-parameter]
   53 | Lz4DecompresDatum(const struct varlena *value) {
      |                   ~~~~~~~~~~~~~~~~~~~~~~^~~~~

@dentiny dentiny force-pushed the hjiang/suppress-compiler-warning branch from 2ad58c6 to 5dd8ffa Compare January 16, 2025 12:02
Y--
Y-- approved these changes Jan 16, 2025
View reviewed changes
Copy link
Collaborator

@Y-- Y-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JelteF JelteF enabled auto-merge (squash) January 16, 2025 15:45
@JelteF JelteF merged commit a4ab75c into duckdb:main Jan 16, 2025
5 checks passed
ritwizsinha pushed a commit to ritwizsinha/pg_duckdb that referenced this pull request Jan 17, 2025
@dentiny @ritwizsinha
[easy] [no-op] Suppress compiler warning (duckdb#543)
bae9cb0 
... otherwise have compiler warning
```
[4/492] Building CXX object src/planner/binder...query_node.dir/ub_duckdb_bind_query_node.cpp.osrc/pgduckdb_detoast.cpp: In function 'varlena* pgduckdb::Lz4DecompresDatum(const varlena*)':
src/pgduckdb_detoast.cpp:53:41: warning: unused parameter 'value' [-Wunused-parameter]
   53 | Lz4DecompresDatum(const struct varlena *value) {
      |                   ~~~~~~~~~~~~~~~~~~~~~~^~~~~
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Y-- Y-- Y-- approved these changes

@JelteF JelteF JelteF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dentiny @Y-- @JelteF