Handle "WITH RECURSIVE" abnormal crashes #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e unions is run, this line assertion will necessarily be triggered, causing the program to terminate.
|
This seems to be a design flaw in pg_get_querydef, which does not adequately account for these scenarios
|
JelteF
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
LGTM, nice that you also created a patch for the upstream issue in Postgres: https://commitfest.postgresql.org/51/5383/
JelteF
approved these changes
Nov 18, 2024
2 tasks
JelteF
pushed a commit
that referenced
this pull request
Nov 23, 2024
After discussion on the pgsql-hackers mailinglist followed by #436, tom lane proposed an additional change: postgres/postgres@94131cd#diff-6c12827097e95912476267d73f3f56e8250b13aad37ab4286c3c7fdab7f30ec7R6367 Let's incorporate that change in our ruleutils files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to be a PG bug. When a CTE expression with multiple unions is run, this line assertion will necessarily be triggered, causing the program to terminate.