Updated (and simplified!) R and Python package to use amalgamation #358
+47
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is a bit borked trying again |
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 23, 2023
Extract the relevant parts of the QUANTILE values at bind time.
This was taking 50+% of the per row run time.
Also add binding to MAD so it doesn't have to construct 0.5 every time.
fixes: duckdblabs/duckdb-internal#358
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Oct 2, 2023
Since not all custom window functions need the previous frame, push responsibility down to the function states that do. Pass around vectors so we have fewer silly arguments.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Oct 2, 2023
Factor out the frame intersection logic for reuse.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Oct 3, 2023
Fix the ModeState to have proper constructors and destructors and then call them.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Oct 3, 2023
Hack around memory leak in PerfectAggregateHashTable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.