-
Notifications
You must be signed in to change notification settings - Fork 2.6k
32-Bit support #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
32-Bit support #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 12, 2023
Reverse the expected order of one test now that we have deterministic ordering of single partitions.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 12, 2023
Move the code for WindowSegmentTree::EvaluateInternal to WindowSegmentTreeState. This hides the implementation details and prepares to fix some memory leaks.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 12, 2023
Fix the right side memory leak. Avoid unnecessary per-chunk memory allocation.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 12, 2023
Plumb the setting through and throw if it is not supported.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 12, 2023
Change API to pass frame lists instead of window setting.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 12, 2023
Support the EXCLUDE modifiers for COUNT(*).
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 12, 2023
Use swap instead of copying.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 12, 2023
Implement exclude syntax for array_agg and friends. Fix non-contiguous NULL detection.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 12, 2023
Use a state machine to walk the frames and cover all the deltas.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 17, 2023
Use pointers to existing frames instead of copying them.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Sep 19, 2023
Make the new exclude clause member optional so we don't have to bump the file version.
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Oct 2, 2023
Still broken but should be closer. Probably just needs a `GetDefault`?
hawkfish
pushed a commit
to hawkfish/duckdb
that referenced
this pull request
Oct 2, 2023
Updated json file with default value. Works now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.