Skip to content

Issue #1888: Nested MIN MAX #1889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 22, 2021
Merged

Issue #1888: Nested MIN MAX #1889

merged 2 commits into from
Jun 22, 2021

Conversation

hawkfish
Copy link
Contributor

Use Value comparisons for MIN / MAX aggregation of nested types, not string casts.
Fix comparison operators for nested Values.

Richard Wesley added 2 commits June 21, 2021 12:45
Issue duckdb#1888: Nested MIN MAX
c228d7f 
Use Value comparisons for MIN/MAX aggregation
of nested types, not string casts.
Fix comparison operators for nested Values.
Merge branch 'master' into hawkfish-nested-minmax
40eddef
@Mytherin
Copy link
Collaborator

Looks good, thanks!

@Mytherin Mytherin merged commit 922380c into duckdb:master Jun 22, 2021
@hawkfish
Copy link
Contributor Author

Thanks for the merge!

I'm going to have a look at vectorising them using cursors and your new ConstantVector::Reference method once I get some performance baselines. I don't think it makes sense to do this for FIRST but it might be worth it for MIN and MAX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hawkfish @Mytherin