[Fix] Prevent logger deadlock #18637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll merge the latest ossivalis changes to see if the Windows failure still reproduces. |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Aug 19, 2025
[Fix] Prevent logger deadlock (duckdb/duckdb#18637) Add enable verification config run (duckdb/duckdb#18467) bump httpfs (duckdb/duckdb#18591) Backport renaming a config name `small_block_size.json` to `block_size_16kB` in NightlyTests (duckdb/duckdb#18581) [Fix] Tidy check ossivalis (duckdb/duckdb#18583) Add verify fetch row config to Main.yml (duckdb/duckdb#18478)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Aug 19, 2025
[Fix] Prevent logger deadlock (duckdb/duckdb#18637) Add enable verification config run (duckdb/duckdb#18467) bump httpfs (duckdb/duckdb#18591) Backport renaming a config name `small_block_size.json` to `block_size_16kB` in NightlyTests (duckdb/duckdb#18581) [Fix] Tidy check ossivalis (duckdb/duckdb#18583) Add verify fetch row config to Main.yml (duckdb/duckdb#18478) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the issue of the logger trying to flush (using the buffer manager lock) while writing a lock entry holding the buffer manager.
Related issue: https://github.com/duckdblabs/duckdb-internal/issues/5454
Solving this long-term requires some re-thinking of the logger, as we can never have logs in code paths we need for flushing/or we cannot flush in any code paths we potentially could log in.