Skip to content

[CI] Temporarily skip triggering R Package Windows (Extensions) job #18628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 21, 2025
Merged

[CI] Temporarily skip triggering R Package Windows (Extensions) job #18628

merged 3 commits into from
Aug 21, 2025

Conversation

hmeriann
Copy link
Contributor

[R / R Package Windows (Extensions) job had been failing 3 times at row.
Every time GH Action states that it lost communication with the runner, failed the job, but it keeps spinning.

I've opened an internal issue for this problem and think we should just skip triggering the job for now.

At the same time we don't have [R / R Package Windows (Extensions) job anymore in main. If we don't need it in v1.3-ossivalis maybe we should just back port those changes from main

@hmeriann hmeriann requested a review from carlopi August 15, 2025 22:30
@carlopi
Copy link
Contributor

carlopi commented Aug 16, 2025

I would assume the problem is encodings extensions taking excessive resources. I would think disabling that for R builds to be a better solution than skipping the whole job.

carlopi
carlopi reviewed Aug 16, 2025
View reviewed changes
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(commented already, I think this is not the right angle)

@hmeriann
Copy link
Contributor Author

I would assume the problem is encodings extensions taking excessive resources. I would think disabling that for R builds to be a better solution than skipping the whole job.

Got it! That’d be more targeted solution

@duckdb-draftbot duckdb-draftbot marked this pull request as draft August 17, 2025 20:14
@hmeriann hmeriann force-pushed the skip-r branch 2 times, most recently from 6d851a1 to 21798e7 Compare August 17, 2025 22:07
@hmeriann
Copy link
Contributor Author

@carlopi could you please take another look at the updates to this PR? Should work now, a test run is here

What I did:
1 - in OOT.cmake added a flag BUILD_ENCODINGS_EXTENSION because the BUILD_COMPLETE_EXTENSION_SET flag was set to true
2 - passed cmake_flags: "-DBUILD_ENCODINGS_EXTENSION=OFF" to the R.yml workflow so the encodings extention only is skipped.

@hmeriann hmeriann marked this pull request as ready for review August 17, 2025 22:30
@hmeriann hmeriann requested a review from carlopi August 17, 2025 22:31
@hmeriann
Copy link
Contributor Author

hmeriann commented Aug 19, 2025 •
edited
Loading

@carlopi
The same problem appeared in Nightly extensions build in main tonight - extensions / Main Extensions / Build / Windows (windows_amd64_mingw, x64-mingw-static, x64-mingw-static)

Which caused the extensions not being uploaded

carlopi
carlopi reviewed Aug 19, 2025
View reviewed changes
carlopi
carlopi suggested changes Aug 19, 2025
View reviewed changes
Copy link
Contributor

@carlopi carlopi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See commend, I would add a NOT MINGW and to .github/config/extensions/encodings and call it a day.

@duckdb-draftbot duckdb-draftbot marked this pull request as draft August 19, 2025 11:07
@hmeriann hmeriann mentioned this pull request Aug 19, 2025
Merged
@hmeriann
Copy link
Contributor Author

hmeriann commented Aug 19, 2025 •
edited
Loading

See commend, I would add a NOT MINGW and to .github/config/extensions/encodings and call it a day.

Thank you for the tip! I've opened another PR, now against main, for the changes in .github/config/extensions/encodings

@hmeriann hmeriann marked this pull request as ready for review August 19, 2025 11:20
carlopi
carlopi reviewed Aug 19, 2025
View reviewed changes
@duckdb-draftbot duckdb-draftbot marked this pull request as draft August 19, 2025 13:31
@hmeriann hmeriann marked this pull request as ready for review August 19, 2025 13:42
Mytherin added a commit that referenced this pull request Aug 20, 2025
@Mytherin
[CI] skip building encodings extension in InvokeCI (#18655)
c397800 
This PR is a temporary solution that makes `InvokeCI` skip building
`encodings` extension.

The problem: GH Actions looses connection with runner while building
`encodings` extension in [extensions / Main Extensions / Build / Windows
(windows_amd64_mingw, x64-mingw-static,
x64-mingw-static)](https://github.com/duckdb/duckdb/actions/runs/17056222844/job/48354362677)
job

Connected to #18628 against
`v1.3-ossivalis` where the same is happening in `[R / R Package Windows
(Extensions)` job.
@hmeriann hmeriann requested a review from carlopi August 20, 2025 09:09
@hannes hannes merged commit e2b0bef into duckdb:v1.3-ossivalis Aug 21, 2025
49 checks passed
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Aug 22, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@df0a3de
ec3f0dc 
Move attached databases from a CatalogSet to a dedicated map of shared pointers (duckdb/duckdb#18693)
Unplug python (in ossivalis) (duckdb/duckdb#18699)
Using a different workflow to release the python package (duckdb/duckdb#18685)
Add WAL test config run (duckdb/duckdb#18683)
[CI] Temporarily skip triggering `R Package Windows (Extensions)` job (duckdb/duckdb#18628)
Load pandas in import cache before binding (duckdb/duckdb#18658)
Remove `PRAGMA enable_verification` in more tests (duckdb/duckdb#18670)
Remove more `PRAGMA enable_verification` (duckdb/duckdb#18664)
Remove `PRAGMA enable_verification` (duckdb/duckdb#18645)
@github-actions github-actions bot mentioned this pull request Aug 22, 2025
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Aug 22, 2025
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@df0a3de (#1402)
c0d529f 
Move attached databases from a CatalogSet to a dedicated map of shared pointers (duckdb/duckdb#18693)
Unplug python (in ossivalis) (duckdb/duckdb#18699)
Using a different workflow to release the python package (duckdb/duckdb#18685)
Add WAL test config run (duckdb/duckdb#18683)
[CI] Temporarily skip triggering `R Package Windows (Extensions)` job (duckdb/duckdb#18628)
Load pandas in import cache before binding (duckdb/duckdb#18658)
Remove `PRAGMA enable_verification` in more tests (duckdb/duckdb#18670)
Remove more `PRAGMA enable_verification` (duckdb/duckdb#18664)
Remove `PRAGMA enable_verification` (duckdb/duckdb#18645)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlopi carlopi Awaiting requested review from carlopi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hmeriann @carlopi @hannes