Skip to content

Conversation

taniabogatsch
Copy link
Contributor

No description provided.

@taniabogatsch taniabogatsch marked this pull request as draft August 21, 2025 09:02
@taniabogatsch taniabogatsch marked this pull request as ready for review August 21, 2025 09:03
@hannes hannes merged commit 1ecf877 into duckdb:v1.3-ossivalis Aug 21, 2025
10 checks passed
@hannes
Copy link
Member

hannes commented Aug 21, 2025

Thanks!

@taniabogatsch taniabogatsch deleted the test-wal-config branch August 21, 2025 14:54
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Aug 22, 2025
Move attached databases from a CatalogSet to a dedicated map of shared pointers (duckdb/duckdb#18693)
Unplug python (in ossivalis) (duckdb/duckdb#18699)
Using a different workflow to release the python package (duckdb/duckdb#18685)
Add WAL test config run (duckdb/duckdb#18683)
[CI] Temporarily skip triggering `R Package Windows (Extensions)` job (duckdb/duckdb#18628)
Load pandas in import cache before binding (duckdb/duckdb#18658)
Remove `PRAGMA enable_verification` in more tests (duckdb/duckdb#18670)
Remove more `PRAGMA enable_verification` (duckdb/duckdb#18664)
Remove `PRAGMA enable_verification` (duckdb/duckdb#18645)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Aug 22, 2025
Move attached databases from a CatalogSet to a dedicated map of shared pointers (duckdb/duckdb#18693)
Unplug python (in ossivalis) (duckdb/duckdb#18699)
Using a different workflow to release the python package (duckdb/duckdb#18685)
Add WAL test config run (duckdb/duckdb#18683)
[CI] Temporarily skip triggering `R Package Windows (Extensions)` job (duckdb/duckdb#18628)
Load pandas in import cache before binding (duckdb/duckdb#18658)
Remove `PRAGMA enable_verification` in more tests (duckdb/duckdb#18670)
Remove more `PRAGMA enable_verification` (duckdb/duckdb#18664)
Remove `PRAGMA enable_verification` (duckdb/duckdb#18645)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Mytherin added a commit that referenced this pull request Aug 25, 2025
…#18700)

Fixes an issue where some code paths pass the entire table chunk to
`DataTable::AppendToIndexes`, while others only pass the "index chunk"
containing only indexed columns.

Now, we always pass both the `table_chunk` and the `index_chunk`, and a
mapping between them. In the absence of indexes, or if there are no
bound indexes, we skip most of the work.

I've also already added the changes of
#18683 here, as they reproduce
multiple bugs fixed by this PR. I'll properly merge ossivalis once this
PR is in. :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants