Add enable verification config run #18467
Merged
+987
−155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # test/configs/verify_fetch_row.json
|
Enable verification runtime with a release build: ~4min With a debug build on nightly: ~1h47min - which I think is also really nice, especially because we also re-add running (the majority of) our fast tests with a debug build! :) We did some hacks there in the past when the build started taking too long. |
|
Failing tests are all unrelated. |
# Conflicts: # .github/workflows/NightlyTests.yml
Mytherin
added a commit
that referenced
this pull request
Aug 19, 2025
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Aug 19, 2025
[Fix] Prevent logger deadlock (duckdb/duckdb#18637) Add enable verification config run (duckdb/duckdb#18467) bump httpfs (duckdb/duckdb#18591) Backport renaming a config name `small_block_size.json` to `block_size_16kB` in NightlyTests (duckdb/duckdb#18581) [Fix] Tidy check ossivalis (duckdb/duckdb#18583) Add verify fetch row config to Main.yml (duckdb/duckdb#18478)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Aug 19, 2025
[Fix] Prevent logger deadlock (duckdb/duckdb#18637) Add enable verification config run (duckdb/duckdb#18467) bump httpfs (duckdb/duckdb#18591) Backport renaming a config name `small_block_size.json` to `block_size_16kB` in NightlyTests (duckdb/duckdb#18581) [Fix] Tidy check ossivalis (duckdb/duckdb#18583) Add verify fetch row config to Main.yml (duckdb/duckdb#18478) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two new configs:
enable_verification.jsonandenable_verification_for_debug.In
Main.yml, we run almost all fast tests with verification enabled (releasebuild).Also, there's an additional nightly debug run now, which runs all fast tests that finish within reasonable time (less than approx. 10s) with verification enabled.
This re-adds a proper
debugtest run. Also, it'll allow us to eventually remove all manualPRAGMA enable_verificationlines from the tests.I've also added a newrelassertbuild to run some of the configurations: latest storage, force storage, and enable verification. The reasoning is that for these I think it's important to trigger internal assertions.With that in mind, we also have to consider the following w.r.t. removingPRAGMA enable_verificationfrom more than 2k tests:- the fast tests will run significantly faster- but, we no longer run verification passes in a lot of our other CI runs (debug, etc.). Maybe we want to add an additionalmake debug+ enable verification to the nightly run?