Restore OSX tests, moving them to single --autoloading available step
#18335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ll/load from logs
…ticular being flaky
…sking changing behaviour for duckdb
6e24799 to
8968899
Compare
|
OSX.yml is a pass after this: https://github.com/carlopi/duckdb/actions/runs/16410520032/job/46365478159 LinuxRelease.yml failure is networking, can be either restarted or also verified on the fork: https://github.com/carlopi/duckdb/actions/runs/16410520037 (once that completes) |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 22, 2025
Restore OSX tests, moving them to single `--autoloading available` step (duckdb/duckdb#18335)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 22, 2025
Restore OSX tests, moving them to single `--autoloading available` step (duckdb/duckdb#18335) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Mytherin
reviewed
Aug 7, 2025
| @@ -112,6 +112,15 @@ void SQLLogicTestRunner::EndLoop() { | |||
| } | |||
| } | |||
|
|
|||
| ExtensionLoadResult SQLLogicTestRunner::LoadExtension(DuckDB &db, const std::string &extension) { | |||
| Connection con(db); | |||
| auto result = con.Query("LOAD " + extension); | |||
There was a problem hiding this comment.
This change means that every single test we run by default runs into at least one exception ("core_functions" failed to load). Can we only run LOAD ... when autoloading is set to a non-default value, instead of enabling this behavior by default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is on top of #18306, moving away from custom logic in the unittester and moving toward using queries (in this case,
LOAD <extension_name>).Also remove
DUCKDB_TEST_REMOTE_INSTALL, now available via config--autoloading all.