Add nightly builds for out-of-tree python extension #18239
Conversation
There was a problem hiding this comment.
This looks great, I would consider:
"publish_to_pypi": ${{ inputs.should-publish }}to be set to false to start with, so basically the duckdb-python repo will be notified but will not publish, and once building is tested to work, sending a PR removing Python.yml AND switching this as relevant.
Or directly in this PR skip publishing for Python.yml, but doing so in lockstep, so to avoid both compete for pypi, it should be a matter of avoiding job twine-upload at https://github.com/duckdb/duckdb/blob/main/.github/workflows/Python.yml#L423
|
Thanks for the review!
Right now the workflow in duckdb-python won't publish to pypi, it will just upload to the s3 staging bucket. |
|
Thanks! |
Backport DB invalidation flag to ossivalis (duckdb/duckdb#18244) Add nightly builds for out-of-tree python extension (duckdb/duckdb#18239) Remove require block size from a batch of tests (duckdb/duckdb#18242)
Backport DB invalidation flag to ossivalis (duckdb/duckdb#18244) Add nightly builds for out-of-tree python extension (duckdb/duckdb#18239) Remove require block size from a batch of tests (duckdb/duckdb#18242) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
See https://github.com/duckdblabs/duckdb-internal/issues/5309
This also adds the changes from 0053604 (since we need the version override on both the bugfix and main branches)