Skip to content

Conversation

lnkuiper
Copy link
Contributor

For backwards compatibility, but we never generate it. I can't add a test because we can only use this function internally, and while I can generate a plan that has it using json_serialize_plan, we don't have a json_execute_serialized_plan function.

Fixes https://github.com/duckdblabs/duckdb-internal/issues/5306

@Tishj
Copy link
Contributor

Tishj commented Jul 14, 2025

@lnkuiper can't you use the methods that were added here to run the serialized statements?

@lnkuiper
Copy link
Contributor Author

lnkuiper commented Jul 14, 2025

@Tishj Thanks for the suggestion but sadly no. The functions cannot be accessed through SQL, so the SQL -> parsed plan (and vice versa) are no use. They only can only be accessed through the optimized logical plan. We can go from SQL -> serialized logical plan, but not the other way around (yet).

@duckdb-draftbot duckdb-draftbot marked this pull request as draft July 14, 2025 08:53
@lnkuiper lnkuiper marked this pull request as ready for review July 14, 2025 09:00
@lnkuiper
Copy link
Contributor Author

I just realised this should target v1.3-ossivalis

@lnkuiper lnkuiper force-pushed the cm_backwards_compat branch from e66baa2 to 34b9539 Compare July 14, 2025 10:28
@lnkuiper lnkuiper changed the base branch from main to v1.3-ossivalis July 14, 2025 10:28
@duckdb-draftbot duckdb-draftbot marked this pull request as draft July 14, 2025 10:28
@lnkuiper lnkuiper marked this pull request as ready for review July 14, 2025 10:28
@Mytherin Mytherin merged commit de3e17e into duckdb:v1.3-ossivalis Jul 14, 2025
51 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jul 14, 2025
Re-add string -> hugeint compressed materialization function (duckdb/duckdb#18234)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jul 14, 2025
Re-add string -> hugeint compressed materialization function (duckdb/duckdb#18234)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@lnkuiper lnkuiper deleted the cm_backwards_compat branch August 6, 2025 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants