Skip to content

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Jul 14, 2025

Unclear why this started failing, we could tweak the parameters, but I think it's more appropriate to skip, investigate what has changed, and remove the skip together with fixing the test.

See this comment #18230 (comment) for the list of failures on main / PRs I had observed.

Unclear why this started failing, we could tweak the parameters, but I think it's more appropriate to
skip, investigate what has changed, and remove the skip together with fixing the test
Copy link
Contributor

@lnkuiper lnkuiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some hidden merge conflict, possibly due to measuring memory more accurately due to #18191

This PR should be closed in favour of #18235, which increases the memory limit slightly so that the test succeeds again

@carlopi carlopi closed this Jul 14, 2025
@carlopi
Copy link
Contributor Author

carlopi commented Jul 14, 2025

Sure, +1

Mytherin added a commit that referenced this pull request Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants