Bump vcpkg-duckdb-ports and test extensions on Windows 10 default stdlib #18205
+28
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change enbales additional run of the test suite for all extensions using C++ stdlib DLL from Visual Studion 2019. This is done to check the compatibility with older versions of C++ stdlib introduced in duckdb#17991 New workflow step is only run for `x64-windows-static-md` build arch. Testing: it was checked in manual CI runs, that added unit test run actually causes a crash when `_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR` is not used.
9f47123 to
aab1858
Compare
|
@staticlibs: I think this includes your PR and roll in relevant fixes (at the moment via I think this is ready to go, and #18149 can then be closed, what do you think? |
Mytherin
reviewed
Jul 15, 2025
aab1858 to
7f6f606
Compare
|
This should be good to go pending CI. |
|
This aims to fix 3 known issues all connected with controlling CMake environment for vcpkg dependencies:
Fixes are all rolled in via https://github.com/duckdb/vcpkg-duckdb-ports/blob/main/ports/vcpkg-cmake/vcpkg_cmake_configure.cmake#L11, that is now the way to override CMake behaviour. We might revisit this to move within extension-ci-tools (in the 1.4.0 run-up), but this does provide a way forward. |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 17, 2025
backport 'Unit Tester Configuration' pt2 (duckdb/duckdb#18282) Bump vcpkg-duckdb-ports to solve OSX linking (duckdb/duckdb#18268) Move aarch64 / arm64 to native github runner (duckdb/duckdb#18269) [Fix] Adjust test for smaller block sizes (duckdb/duckdb#18255) Bump vcpkg-duckdb-ports and test extensions on Windows 10 default stdlib (duckdb/duckdb#18205)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 17, 2025
backport 'Unit Tester Configuration' pt2 (duckdb/duckdb#18282) Bump vcpkg-duckdb-ports to solve OSX linking (duckdb/duckdb#18268) Move aarch64 / arm64 to native github runner (duckdb/duckdb#18269) [Fix] Adjust test for smaller block sizes (duckdb/duckdb#18255) Bump vcpkg-duckdb-ports and test extensions on Windows 10 default stdlib (duckdb/duckdb#18205) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two not so independent changes:
vcpkg-duckdb-portscommit to include duckdb/vcpkg-duckdb-ports@fcdaf72, that adds:to
vcpkg-cmakeport.vssandazure(PR that adapt them are ready, needs to be merged and then bumped, see remove overlay ports duckdb-vss#64 and Remove overlay ports duckdb-azure#111)If Windows CI for this PR passes, then good to be merged.