Skip to content

[Fix] Missing block when renaming fields #18293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2025
Merged

[Fix] Missing block when renaming fields #18293

merged 1 commit into from
Jul 18, 2025

Conversation

taniabogatsch
Copy link
Contributor

@taniabogatsch taniabogatsch commented Jul 17, 2025 •
edited
Loading

RenameFieldInfo did not have an override for GetColumnName causing a missing commit of the alter in the undo buffer here:

			case CatalogType::TABLE_ENTRY:
				if (!column_name.empty()) {
					D_ASSERT(entry.type != CatalogType::RENAMED_ENTRY);
					auto &table_entry = entry.Cast<DuckTableEntry>();
					D_ASSERT(table_entry.IsDuckTable());
					// write the alter table in the log
					table_entry.CommitAlter(column_name);
				}
				break;

I've also removed the no_block_verification flag - we should not skip this for any test.

Close https://github.com/duckdblabs/duckdb-internal/issues/5206

@Mytherin Mytherin merged commit 158b1ea into duckdb:v1.3-ossivalis Jul 18, 2025
46 of 47 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jul 18, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@158b1ea
47a9f4f 
[Fix] Missing block when renaming fields (duckdb/duckdb#18293)
Bump vcpkg-duckdb-ports, now fixing also mingw (duckdb/duckdb#18300)
resolve hidden merge conflict with duplicate db name in json configs (duckdb/duckdb#18292)
[Unittester] Add autoloading option (duckdb/duckdb#18290)
Fixup Main.yml for v1.3-ossivalis post duckdb/duckdb#18282 (duckdb/duckdb#18289)
@github-actions github-actions bot mentioned this pull request Jul 18, 2025
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jul 18, 2025
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@158b1ea (#1338)
5c61588 
[Fix] Missing block when renaming fields (duckdb/duckdb#18293)
Bump vcpkg-duckdb-ports, now fixing also mingw (duckdb/duckdb#18300)
resolve hidden merge conflict with duplicate db name in json configs (duckdb/duckdb#18292)
[Unittester] Add autoloading option (duckdb/duckdb#18290)
Fixup Main.yml for v1.3-ossivalis post duckdb/duckdb#18282 (duckdb/duckdb#18289)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@taniabogatsch taniabogatsch deleted the block-verification branch July 18, 2025 07:44
@taniabogatsch taniabogatsch mentioned this pull request Jul 18, 2025
Merged
Mytherin added a commit that referenced this pull request Jul 21, 2025
@Mytherin
[Fix] Block verification for add and drop field info (#18302)
35391cb 
Follow-up to #18293.
Close duckdblabs/duckdb-internal#5206.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taniabogatsch @Mytherin