Skip to content

Bump vcpkg-duckdb-ports to solve OSX linking #18268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 16, 2025
Merged

Bump vcpkg-duckdb-ports to solve OSX linking #18268

merged 1 commit into from
Jul 16, 2025

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Jul 16, 2025

Tested locally with:

OSX_BUILD_UNIVERSAL=1 VCPKG_TOOLCHAIN_PATH=/Users/carlo/vcpkg/scripts/buildsystems/vcpkg.cmake USE_MERGED_VCPKG_MANIFEST=1 CORE_EXTENSIONS="avro" GEN=ninja make

on v1.3-ossivalis or with this commit in.

Difference is that a bunch of lines like:

ld: warning: object file (/Users/carlo/duckdb_main_clone/build/release/vcpkg_installed/arm64-osx/lib/libavro.a[2](allocation.c.o)) was built for newer 'macOS' version (15.0) than being linked (11.0)
ld: warning: object file (/Users/carlo/duckdb_main_clone/build/release/vcpkg_installed/arm64-osx/lib/libavro.a[3](array.c.o)) was built for newer 'macOS' version (15.0) than being linked (11.0)
ld: warning: object file (/Users/carlo/duckdb_main_clone/build/release/vcpkg_installed/arm64-osx/lib/libavro.a[4](codec.c.o)) was built for newer 'macOS' version (15.0) than being linked (11.0)

will (rightly) not be there anymore, meaning the vcpkg dependencies have been built with correct target option taken from duckdb/vcpkg-duckdb-ports@43e8fec

@carlopi
Copy link
Contributor Author

carlopi commented Jul 16, 2025

CI failure is not really relevant, I can't understand what it is but I also have not really looked. Fun stuff.

@Mytherin Mytherin merged commit 9d0bd71 into duckdb:v1.3-ossivalis Jul 16, 2025
50 of 51 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jul 17, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@a1283de
f15090d 
backport 'Unit Tester Configuration' pt2 (duckdb/duckdb#18282)
Bump vcpkg-duckdb-ports to solve OSX linking (duckdb/duckdb#18268)
Move aarch64 / arm64 to native github runner (duckdb/duckdb#18269)
[Fix] Adjust test for smaller block sizes (duckdb/duckdb#18255)
Bump vcpkg-duckdb-ports and test extensions on Windows 10 default stdlib (duckdb/duckdb#18205)
@github-actions github-actions bot mentioned this pull request Jul 17, 2025
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jul 17, 2025
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@a1283de (#1336)
90d9443 
backport 'Unit Tester Configuration' pt2 (duckdb/duckdb#18282)
Bump vcpkg-duckdb-ports to solve OSX linking (duckdb/duckdb#18268)
Move aarch64 / arm64 to native github runner (duckdb/duckdb#18269)
[Fix] Adjust test for smaller block sizes (duckdb/duckdb#18255)
Bump vcpkg-duckdb-ports and test extensions on Windows 10 default stdlib (duckdb/duckdb#18205)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@carlopi carlopi deleted the bump_vcpkg_duckdb_ports_to_solve_osx_linking branch August 17, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@carlopi @Mytherin