Skip to content

Use _unsigned_ hugeint for compressed materialization strings #18128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

Use _unsigned_ hugeint for compressed materialization strings #18128

merged 1 commit into from
Jul 3, 2025

Conversation

lnkuiper
Copy link
Contributor

@lnkuiper lnkuiper commented Jul 3, 2025

Fixes #18124

@Mytherin
Copy link
Collaborator

Mytherin commented Jul 3, 2025

Thanks! LGTM. Should this target v1.3.2?

@lnkuiper lnkuiper changed the base branch from main to v1.3-ossivalis July 3, 2025 08:46
@lnkuiper lnkuiper marked this pull request as draft July 3, 2025 08:47
@lnkuiper lnkuiper marked this pull request as ready for review July 3, 2025 08:47
@lnkuiper
Copy link
Contributor Author

lnkuiper commented Jul 3, 2025

Good idea! I've retargeted

@Mytherin Mytherin merged commit 54a0102 into duckdb:v1.3-ossivalis Jul 3, 2025
50 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Jul 3, 2025

Thanks!

@JasonPunyon
Copy link
Contributor

Thanks y'all!

@lnkuiper lnkuiper deleted the issue18124 branch July 8, 2025 08:25
krlmlr added a commit to krlmlr/duckdb-r that referenced this pull request Jul 9, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@54a0102
2b7daa0 
Use _unsigned_ hugeint for compressed materialization strings (duckdb/duckdb#18128)
Absorb patch from duckdb/duckdb#18107 (duckdb/duckdb#18114)
CI: Actually correctly skip building unnecessary extensions (duckdb/duckdb#18119)
krlmlr added a commit to krlmlr/duckdb-r that referenced this pull request Jul 9, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@54a0102
1ff6a5f 
Use _unsigned_ hugeint for compressed materialization strings (duckdb/duckdb#18128)
Absorb patch from duckdb/duckdb#18107 (duckdb/duckdb#18114)
CI: Actually correctly skip building unnecessary extensions (duckdb/duckdb#18119)
@lnkuiper lnkuiper mentioned this pull request Aug 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected Sort Results
3 participants
@lnkuiper @Mytherin @JasonPunyon