shared_ptr<HTTPUtil>& must be reached from FileOpener #18107
Merged
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this PR, there are situations where `httpfs` extension defaults to own HTTPFSUtil, instead of using the global registered one. I think while this currently work, it's somewhat of a code smell, and basically prevent other extensions (or clients, such as duckdb-wasm) to have a clean path to override the default http_util to be used. This is possibly also a problem connected to introduction of curl in the `httpfs` extension, since it's not possible for `httpfs` to offer two interfaces, and register one or the other depending on settings. This commit forces FileOpener to have a way to return a reference to the original shared_ptr<HTTPUtil> (possibly caching on costructor / other ways). Then the main improvement is the chagnge (currently via a patch) that allows in duckdb-httpfs. This is an improved / slimmer version of duckdb#18103, thanks to feedback from @Mytherin.
303f809 to
b298ba8
Compare
|
Thanks! |
carlopi
added a commit
to carlopi/duckdb_httpfs
that referenced
this pull request
Jul 1, 2025
carlopi
added a commit
to duckdb/duckdb-httpfs
that referenced
this pull request
Jul 2, 2025
Apply patch from duckdb/duckdb#18107
carlopi
added a commit
to carlopi/duckdb
that referenced
this pull request
Jul 2, 2025
Mytherin
added a commit
that referenced
this pull request
Jul 2, 2025
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Jul 9, 2025
shared_ptr<HTTPUtil>& must be reached from FileOpener (duckdb/duckdb#18107)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Jul 9, 2025
Use _unsigned_ hugeint for compressed materialization strings (duckdb/duckdb#18128) Absorb patch from duckdb/duckdb#18107 (duckdb/duckdb#18114) CI: Actually correctly skip building unnecessary extensions (duckdb/duckdb#18119)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Jul 9, 2025
shared_ptr<HTTPUtil>& must be reached from FileOpener (duckdb/duckdb#18107)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Jul 9, 2025
Use _unsigned_ hugeint for compressed materialization strings (duckdb/duckdb#18128) Absorb patch from duckdb/duckdb#18107 (duckdb/duckdb#18114) CI: Actually correctly skip building unnecessary extensions (duckdb/duckdb#18119)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this PR, there are situations where
httpfsextension defaults to own HTTPFSUtil, instead of using the global registered one. I think while this currently work, it's somewhat of a code smell, and basically prevent other extensions (or clients, such as duckdb-wasm) to have a clean path to override the default http_util to be used.This is possibly also a problem connected to introduction of curl in the
httpfsextension, since it's not possible forhttpfsto offer two interfaces, and register one or the other depending on settings.This commit forces FileOpener to have a way to return a reference to the original shared_ptr (possibly caching on costructor / other ways). Then the main improvement is the change (currently via a patch) that allows in duckdb-httpfs.
This is a less clunky / slimmer version of #18103, thanks to feedback from @Mytherin.