partially restore deprecated http logging settings #18150
Merged
+61
−46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Jul 9, 2025
partially restore deprecated http logging settings (duckdb/duckdb#18150)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Jul 9, 2025
partially restore deprecated http logging settings (duckdb/duckdb#18150)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes #17714.
The problem was that we broke the existing http logging infrastructure when moving to the new logger.
In this PR i partially the old behaviour for stdout logging by enabling the new http logger with the
stdoutstorage whenever theenable_http_loggingsetting is set. This means that the stdout logging now works similarly to how it did before.I did not manage to find a good way to restore the http logging to a file though. However in DuckDB v1.4 we will be able to do this by using #17692