Fix handling dynamic table filters in RemoveUnusedColumns #18033
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mytherin
reviewed
Jun 24, 2025
| PRAGMA enable_verification | ||
|
|
||
| statement ok | ||
| INSTALL tpch |
There was a problem hiding this comment.
This should be require tpch
| CALL dbgen(sf=0.1); | ||
|
|
||
| statement ok | ||
| SELECT * FROM (SELECT * FROM lineitem LIMIT 500) ORDER BY l_orderkey DESC LIMIT 10; |
There was a problem hiding this comment.
dbgen is pretty slow - can we either add this to one of the existing TPC-H tests (e.g. test/sql/tpch/tpch_topn.test_slow) or write a failing test that uses a (smaller synthetic) dataset that likely also exhibits the problem.
| @@ -256,7 +259,12 @@ void RemoveUnusedColumns::VisitOperator(LogicalOperator &op) { | |||
| ColumnBinding filter_binding(get.table_index, index.GetIndex()); | |||
| auto column_ref = make_uniq<BoundColumnRefExpression>(std::move(column_type), filter_binding); | |||
| auto filter_expr = filter.second->ToExpression(*column_ref); | |||
| VisitExpression(&filter_expr); | |||
| if (filter_expr->GetExpressionClass() == ExpressionClass::BOUND_CONSTANT) { | |||
There was a problem hiding this comment.
Can we use filter_expr->IsScalar() instead?
| VisitExpression(&filter_expr); | ||
| if (filter_expr->GetExpressionClass() == ExpressionClass::BOUND_CONSTANT) { | ||
| AddBinding(*column_ref); | ||
| column_refs.push_back(std::move(column_ref)); |
There was a problem hiding this comment.
Instead of having the special code here - can we just set filter_expr = std::move(column_ref)? Then we don't need the extra column_refs vector either.
|
Can we also retarget this to |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 28, 2025
Fix handling dynamic table filters in RemoveUnusedColumns (duckdb/duckdb#18033)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 28, 2025
Fix handling dynamic table filters in RemoveUnusedColumns (duckdb/duckdb#18033) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #18028. ToExpression of dynamic table filter may return constant true expression which causes the column referenced in the filter to be lost.