Bring back libduckdb-src.zip as release artifact #18019
Conversation
.github/workflows/LinuxRelease.yml
Outdated
| zip -j duckdb_cli-linux-${{ matrix.config.arch }}.zip build/release/duckdb | ||
| gzip -9 -k -n -c build/release/duckdb > duckdb_cli-linux-${{ matrix.config.arch }}.gz | ||
| zip -j libduckdb-linux-${{ matrix.config.arch }}.zip build/release/src/libduckdb*.* src/amalgamation/duckdb.hpp src/include/duckdb.h | ||
| ./scripts/upload-assets-to-staging.sh github_release libduckdb-linux-${{ matrix.config.arch }}.zip duckdb_cli-linux-${{ matrix.config.arch }}.zip duckdb_cli-linux-${{ matrix.config.arch }}.gz | ||
| zip -j libduckdb-src.zip src/amalgamation/duckdb.hpp src/amalgamation/duckdb.cpp src/include/duckdb.h src/include/duckdb_extension.h | ||
| ./scripts/upload-assets-to-staging.sh github_release libduckdb-src.zip libduckdb-linux-${{ matrix.config.arch }}.zip duckdb_cli-linux-${{ matrix.config.arch }}.zip duckdb_cli-linux-${{ matrix.config.arch }}.gz |
There was a problem hiding this comment.
TBH, I don't know how libduckdb-src.zip will be published as a GitHub release artifact after it's uploaded here.
Also, since this is a matrix job, the file will be uploaded twice. However, AFAICT, this used to be the case in the past too.
There was a problem hiding this comment.
Then maybe can be explicitly written only in one of the paths? Or maybe better, have a separate step that takes care of putting together sources / run the amalgamation?
| @@ -109,10 +109,12 @@ jobs: | |||
| AWS_ACCESS_KEY_ID: ${{ secrets.S3_DUCKDB_STAGING_ID }} | |||
| AWS_SECRET_ACCESS_KEY: ${{ secrets.S3_DUCKDB_STAGING_KEY }} | |||
| run: | | |||
| python3 scripts/amalgamation.py | |||
| zip -j duckdb_cli-linux-${{ matrix.config.arch }}.zip build/release/duckdb | |||
| gzip -9 -k -n -c build/release/duckdb > duckdb_cli-linux-${{ matrix.config.arch }}.gz | |||
| zip -j libduckdb-linux-${{ matrix.config.arch }}.zip build/release/src/libduckdb*.* src/amalgamation/duckdb.hpp src/include/duckdb.h | |||
There was a problem hiding this comment.
This should really fail right now since src/amalgamation/duckdb.hpp won't exist without calling the amalgamation script. 🤔
There was a problem hiding this comment.
I learned that zip treats missing files as a warning - unless -MM is used. 🙈
|
Also given I took a look, should this go to |
ecf7b6a to
54a879b
Compare
|
@carlopi I've moved the logic into a separate step and also changed the base branch to Be warned that I haven't tested the job yet, but I'd love to see how you usually test changes to the release process without waiting for the next release. 😄 |
|
Thanks! |
Issue duckdb/duckdb#18035: Zero Fill TIMESTAMP_NS (duckdb/duckdb#18045) Bring back libduckdb-src.zip as release artifact (duckdb/duckdb#18019)
Issue duckdb/duckdb#18035: Zero Fill TIMESTAMP_NS (duckdb/duckdb#18045) Bring back libduckdb-src.zip as release artifact (duckdb/duckdb#18019) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
DuckDB 1.2.2 was the last release that included
libduckdb-src.zip.It was removed in f0e821d and 055334e by accident.