Add Stack Trace marker to stack trace #18089
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like this change to be backported to the 1.3 branch (since the stack trace addition is there too). Should I create the PR against that branch, or against main? |
1.3.2 will be build from the branch |
Since duckdb#18023 stack traces are now being added in ConstructFinalMessage. However they were not using the "Stack trace:" prefix that is used for all other stack traces. This makes it hard extract/remove these specific stack traces from the resulting error message. This adds that same prefix.
50ebc67 to
cbcfa3a
Compare
Done |
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jul 1, 2025
Add Stack Trace marker to stack trace (duckdb/duckdb#18089)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Jul 9, 2025
Add Stack Trace marker to stack trace (duckdb/duckdb#18089)
krlmlr
added a commit
to krlmlr/duckdb-r
that referenced
this pull request
Jul 9, 2025
Add Stack Trace marker to stack trace (duckdb/duckdb#18089)
github-actions bot
pushed a commit
to krlmlr/duckdb-r
that referenced
this pull request
Jul 9, 2025
Add Stack Trace marker to stack trace (duckdb/duckdb#18089)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #18023 stack traces are now being added in ConstructFinalMessage. However they were not using the "Stack trace:" prefix that is used for all other stack traces. This makes it hard extract/remove these specific stack traces from the resulting error message. This adds that same prefix.