Skip to content

Properly handle empty RHS in IE Join #18067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2025
Merged

Properly handle empty RHS in IE Join #18067

merged 2 commits into from
Jun 27, 2025

Conversation

lnkuiper
Copy link
Contributor

hawkfish
hawkfish suggested changes Jun 26, 2025
View reviewed changes
Copy link
Contributor

@hawkfish hawkfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good - dunno how easy it would be to add a small test?

@lnkuiper
Copy link
Contributor Author

Thanks for the review! Took me a while but I was able to reproduce with a small test :)

@duckdb-draftbot duckdb-draftbot marked this pull request as draft June 26, 2025 15:27
@lnkuiper lnkuiper marked this pull request as ready for review June 26, 2025 15:27
@Mytherin Mytherin merged commit 4eccabd into duckdb:v1.3-ossivalis Jun 27, 2025
53 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jun 28, 2025
@krlmlr
vendor: Update vendored sources to duckdb/duckdb@4eccabd
2c0c1d7 
Properly handle empty RHS in IE Join (duckdb/duckdb#18067)
Issue duckdb/duckdb#18047: TIMESTAMP_TZ Upcast Costs (duckdb/duckdb#18064)
@github-actions github-actions bot mentioned this pull request Jun 28, 2025
Merged
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jun 28, 2025
@github-actions @krlmlr
vendor: Update vendored sources to duckdb/duckdb@4eccabd (#1314)
fb8ecd1 
Properly handle empty RHS in IE Join (duckdb/duckdb#18067)
Issue duckdb/duckdb#18047: TIMESTAMP_TZ Upcast Costs (duckdb/duckdb#18064)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@hawkfish hawkfish hawkfish approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
Ready To Merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lnkuiper @Mytherin @hawkfish