Skip to content

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Jun 5, 2025

Step further bringing github caching back to be functional, that should translate to faster evaluation cycles on PRs.

Problem is that currently for the 3 set of linux extensions, that are a bulk of CI time, cache items are added on every PR, making so that cache items from base branches will get evicted, and means less effective caching.

Basic is as follows:

  • PR can access cache items from any predecessor. Cache items produced by PRs can only be reused by the exact same PR
  • Base branches (say v1.3-ossivalis or main) can access cache only from other base branches, but their cache items can be used by anyone.
  • When total cache size grows past 10 GB, GitHub will evict older items (that are likely to be the base branches one)

Current situation that happens somewhat frequently is that PR pollute the cache, keep invalidating it, eventually removing the only valuable items in there. This PR aims at producing less items in the global cache.

@Mytherin Mytherin merged commit 416b66d into duckdb:v1.3-ossivalis Jun 5, 2025
48 checks passed
@Mytherin
Copy link
Collaborator

Mytherin commented Jun 5, 2025

Thanks!

github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jun 5, 2025
arrow_output_version option to produce arrow depending on a format version. (duckdb/duckdb#17791)
Support glibc 2.28 environments in 1.3.x (duckdb/duckdb#17814)
Avoid saving ccache on pull_requests (duckdb/duckdb#17810)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jun 5, 2025
arrow_output_version option to produce arrow depending on a format version. (duckdb/duckdb#17791)
Support glibc 2.28 environments in 1.3.x (duckdb/duckdb#17814)
Avoid saving ccache on pull_requests (duckdb/duckdb#17810)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
@carlopi carlopi deleted the avoid_saving_caches_on_prs branch August 17, 2025 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants