Thanks! Can we use StringUtil::CharacterIsSpace instead?

I actually ran into an issue with std::isspace on Windows as well when testing there, so I think this is great to rip out.

Don't know how this function is used, so this comment may be off. Just perhaps it is better to check explicitly for the set of space characters defined in the parser (like scanner_isspace in Postgres). In case when the parser and C stdlib disagree what is space and what is not.

edit: sent this before seeing the comment above, apparently CharacterIsSpace is doing that.

Thanks for the comments, isspace + explicit classic locale, scanner_isspace or StringUtil::CharacterIsSpace all have the same logic for which characters to accept, I changed to StringUtil::CharacterIsSpace.

There are still a couple of mentions in the shell and a bunch in icu code, those might be also worth tackling in a follow up.

https://github.com/search?q=org%3Aduckdb%20isspace&type=code shows default isspace is used in other extensions, so that might also be worth a look.

Thanks!