Skip to content

Conversation

carlopi
Copy link
Contributor

@carlopi carlopi commented Jun 12, 2025

I think this should be somehow trivial, solves a warning on duckdb-wasm (where size_t is 32 bits).

@carlopi carlopi requested a review from lnkuiper June 12, 2025 08:59
@carlopi carlopi force-pushed the fix_warning_type_mismatch branch from e296e14 to ba14578 Compare June 12, 2025 09:20
@carlopi carlopi marked this pull request as draft June 12, 2025 09:34
@carlopi carlopi force-pushed the fix_warning_type_mismatch branch from ba14578 to 66ff3a7 Compare June 12, 2025 09:34
@carlopi carlopi marked this pull request as ready for review June 12, 2025 09:35
Copy link
Contributor

@lnkuiper lnkuiper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@carlopi
Copy link
Contributor Author

carlopi commented Jun 12, 2025

Failure is an already tracked logger non-determinism.

@Mytherin Mytherin merged commit 86f0efd into duckdb:v1.3-ossivalis Jun 12, 2025
51 of 52 checks passed
@Mytherin
Copy link
Collaborator

Thanks!

@carlopi carlopi deleted the fix_warning_type_mismatch branch June 12, 2025 15:57
github-actions bot pushed a commit to duckdb/duckdb-r that referenced this pull request Jun 12, 2025
[Fix] Serialisation error for invalid block ID in index deserialization (duckdb/duckdb#17900)
 Skipping failing on OSX Release part (duckdb/duckdb#17899)
Fix mismatch between idx_t (64 bits) and size_t (implementation dependent) (duckdb/duckdb#17898)
github-actions bot added a commit to duckdb/duckdb-r that referenced this pull request Jun 12, 2025
[Fix] Serialisation error for invalid block ID in index deserialization (duckdb/duckdb#17900)
 Skipping failing on OSX Release part (duckdb/duckdb#17899)
Fix mismatch between idx_t (64 bits) and size_t (implementation dependent) (duckdb/duckdb#17898)

Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants