Add option to control parquet NaN pruning #17883
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
github-actions bot
pushed a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 12, 2025
Add option to control parquet NaN pruning (duckdb/duckdb#17883) Add urllib3 dependency and improve fixture download reliability (duckdb/duckdb#17880) Add array indices to nested paths in `json_each`/`json_tree` (duckdb/duckdb#17878)
github-actions bot
added a commit
to duckdb/duckdb-r
that referenced
this pull request
Jun 12, 2025
Add option to control parquet NaN pruning (duckdb/duckdb#17883) Add urllib3 dependency and improve fixture download reliability (duckdb/duckdb#17880) Add array indices to nested paths in `json_each`/`json_tree` (duckdb/duckdb#17878) Co-authored-by: krlmlr <krlmlr@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #16962, which partly reverts the newly introduced nan-handling behavior by putting it behind a new boolean named parameter
can_have_nanin theparquet_scanandCOPY ... FROM (FORMAT PARQUET)functions.Until the parquet spec decides on how to deal with NaN values from the perspective of floating-point filter pruning, this is probably the better option to avoid performance regression in the common case, closing: #17855